util_libs icon indicating copy to clipboard operation
util_libs copied to clipboard

SERIAL_AUTO_CR inconsistently implemented

Open bennoleslie opened this issue 4 years ago • 1 comments

In some implementation (rockpro64) the CR is sent after the LF, while in others (such as imx) it is sent prior to the LF.

I think it should be sent prior (as in, imx is correct). Is there a reason the rockpro64 is implemented differently?

bennoleslie avatar Sep 26 '20 17:09 bennoleslie

yes this is a copy&paste bug that keeps spreading. I've already upstreamed a few patches that fix this for the platform I have access to.

See also https://github.com/seL4/util_libs/pull/38#discussion_r484764026

axel-h avatar Sep 27 '20 20:09 axel-h