util_libs icon indicating copy to clipboard operation
util_libs copied to clipboard

libethdrivers,imx: Reintroduce ethif_imx6_init

Open kent-mcleod opened this issue 4 years ago • 4 comments
trafficstars

This init function is used by ethif_new_lwip_driver and was previously removed in an earlier refactor. This commit reintroduces it.

Signed-off-by: Kent McLeod [email protected]

kent-mcleod avatar Nov 17 '21 00:11 kent-mcleod

As a follow-up, should we have a CI test that a system using LWIP still builds? Since i.MX6 i supported in QEMU, we could later even add a check that this actually works

axel-h avatar Nov 22 '21 10:11 axel-h

As a follow-up, should we have a CI test that a system using LWIP still builds? Since i.MX6 i supported in QEMU, we could later even add a check that this actually works

This would be the closest: https://github.com/seL4/camkes/pull/13

kent-mcleod avatar Nov 24 '21 03:11 kent-mcleod

I'm fine with merging this when the style issue and the missing return are addressed. Leaving the include file for now is a nice-to-have thing.

axel-h avatar Dec 09 '21 17:12 axel-h

@kent-mcleod: do you want to merge this?

axel-h avatar Mar 08 '22 23:03 axel-h