seL4 icon indicating copy to clipboard operation
seL4 copied to clipboard

Only access IOAPIC registers that are actually present

Open wom-bat opened this issue 3 years ago • 7 comments

IOAPICS can have varying numbers of lines attached. The actual number can be accessed in the top 16 bits of the version register.

Rather than assuming fixed 24 lines per IRQ, read the actual number and use that.

Signed-off-by: Peter Chubb [email protected]

wom-bat avatar Jul 29 '22 02:07 wom-bat

Maybe a comment should be added to ioredtbl_high to explain that IOAPIC_IRQ_LINES is used as an upper bound of how much memory to reserve for book keeping.

Fixed.

wom-bat avatar Jul 29 '22 04:07 wom-bat

Is this blocked on a verification spec update?

kent-mcleod avatar Aug 12 '22 00:08 kent-mcleod

Is this blocked on a verification spec update?

Spec and proof, yes.

lsf37 avatar Aug 12 '22 06:08 lsf37

Problem I'm trying to solve is machine hang when attempting to access non-existent registers.

wom-bat avatar Aug 22 '22 04:08 wom-bat

Spec and proof, yes.

@lsf37, are proof updates scheduled or in progres?

Problem I'm trying to solve is machine hang when attempting to access non-existent registers.

@wom-bat, is this urgent? I don't think we can merge it until proofs are ready. If proof updates aren't scheduled and the changes are urgent, we could put it behind a temporary compile-time config? Otherwise the PR is blocked until proofs are done AFAIK.

kent-mcleod avatar Aug 25 '22 22:08 kent-mcleod

Spec and proof, yes.

@lsf37, are proof updates scheduled or in progres?

Unless someone has funding for it it'll have to wait until I have spare time (with a bit of luck in the week after next) or someone else picks it up.

lsf37 avatar Aug 26 '22 07:08 lsf37

Rebased and squashed in preparation for the proof update.

lsf37 avatar Feb 25 '24 11:02 lsf37