microkit icon indicating copy to clipboard operation
microkit copied to clipboard

added concat of headers as a build output

Open isubasinghe opened this issue 2 years ago • 3 comments

Motivation

These artefacts are needed as part of the verification pipeline, these concatenated files are cleaned and then fed into the C parser.

isubasinghe avatar Nov 26 '23 23:11 isubasinghe

I've changed the build to produce main_verification.c so it's obvious what it's for. With the seL4 kernel build artifacts it's hard to know with the naming convention what is used for what. Any opinions @lsf37 before I merge?

Ivan-Velickovic avatar Dec 03 '23 23:12 Ivan-Velickovic

No opinions from me on that one. Ideally, the concatenated C file that the verification sees should also be what the compiler gets, unless you are also planning to do binary verification. We're no longer doing that for the kernel (there it's because of BV), but if you want to eliminate the preprocessor from the trust chain, then that's the way to do it.

lsf37 avatar Dec 04 '23 00:12 lsf37

No opinions from me on that one. Ideally, the concatenated C file that the verification sees should also be what the compiler gets

Okay yes we should definitely do that then. Thanks.

Ivan-Velickovic avatar Dec 04 '23 01:12 Ivan-Velickovic

Going to close this for now and re-open/make a new PR once the verification for Microkit is caught up to speed with the latest Microkit and we start working on adding verification checks for libmicrokit to the CI.

Ivan-Velickovic avatar Oct 27 '24 08:10 Ivan-Velickovic