l4v icon indicating copy to clipboard operation
l4v copied to clipboard

Add `hoare_from_abs` rule

Open michaelmcinerney opened this issue 2 years ago • 3 comments

michaelmcinerney avatar Sep 28 '22 08:09 michaelmcinerney

I didn't put much thought into the names of the new lemmas. Maybe valid_cross or hoare_cross might be slightly better than hoare_from_abs. But I imagine that someone would have to search for a theorem with valid and corres_underlying to find it, anyway. These lemmas are visible in AInvs, Refine, and CRefine, at least

michaelmcinerney avatar Sep 28 '22 11:09 michaelmcinerney

I'm fine with the names. Small comments, but nothing semantic.

Xaphiosis avatar Oct 05 '22 16:10 Xaphiosis

I have responded to the comments, and also added a type signature for ex_abs_underlying

michaelmcinerney avatar Oct 13 '22 01:10 michaelmcinerney

This looks ready to merge now. @michaelmcinerney can you please squash that one commit?

lsf37 avatar Nov 10 '22 03:11 lsf37

I tried to squash that one commit, but I'm not sure what's happened, with all the other merge stuff

michaelmcinerney avatar Nov 10 '22 04:11 michaelmcinerney

hm, yes, that looks not good :-) Let me check.

lsf37 avatar Nov 10 '22 04:11 lsf37

Ok, I think I fixed it. (Basically started a new branch from master, cherry-picked your two commits and squashed them)

lsf37 avatar Nov 10 '22 04:11 lsf37

Thanks!

michaelmcinerney avatar Nov 10 '22 04:11 michaelmcinerney