camkes-vm icon indicating copy to clipboard operation
camkes-vm copied to clipboard

vm_arm: move vpci code to dedicated module

Open axel-h opened this issue 1 year ago • 3 comments

This PR is on top of https://github.com/seL4/camkes-vm/pull/73 and uses the DTB generation refactoring to move the vpci support imto a dedicate module.

axel-h avatar Mar 31 '23 13:03 axel-h

I'm working on generalizing that cross-VM connector. My intention is to support mapping as RAM and providing MMIO-style interface in addition to that PCI interface. So perhaps crossvm.c should not depend on PCI support that hard.

hlyytine avatar Jun 03 '23 07:06 hlyytine

I'm working on generalizing that cross-VM connector. My intention is to support mapping as RAM and providing MMIO-style interface in addition to that PCI interface. So perhaps crossvm.c should not depend on PCI support that hard.

It would take another PR for this file to relax the dependency then. At the moment that seem a big practical dependency, that is why I made this change.

axel-h avatar Jun 06 '23 14:06 axel-h

After some more refactoring, making a VPCI module seems not really useful, as this would be just a wrapper around the vPCI helper coede in libsel4vmmplatsupport then. The refactoring seem an improvement, though.

axel-h avatar Jun 06 '23 16:06 axel-h