addressbook-level4 icon indicating copy to clipboard operation
addressbook-level4 copied to clipboard

AddCommand: On success, should not update filtered list to show all

Open Zhiyuan-Amos opened this issue 7 years ago • 2 comments

AddCommand should not update Model's filtered list to show all. Rather, it should show the current filtered list + the added person.

Zhiyuan-Amos avatar Aug 31 '17 15:08 Zhiyuan-Amos

Rather, it should show the current filtered list + the added person.

We should not add the new person to the filtered list if the new person does not match the filter cirteria though.

On second thoughts, perhaps the current behavior is not that bad. In some cases the user may no longer be interested in the previous filtered list. If he is, he can use the 'up' button to run the previous find command.

Something I would like to do though is to be able to highlight the person that was just edited/added/deleted, for a few seconds. I think that too might require a change to the model architecture, possibly requiring another 'view model' layer. The filtered list too should be part of that layer. The current model should be reserved for keeping the 'one source of truth' that we save to the storage.

damithc avatar Sep 01 '17 00:09 damithc

In some cases the user may no longer be interested in the previous filtered list.

I guess it's a bit hard to argue for the use case because we don't really have a user base to find out which behavior they prefer :P

Something I would like to do though is to be able to highlight the person that was just edited/added/deleted, for a few seconds. I think that too might require a change to the model architecture, possibly requiring another 'view model' layer.

Will label this as epic then :P

Zhiyuan-Amos avatar Sep 01 '17 06:09 Zhiyuan-Amos