addressbook-level4 icon indicating copy to clipboard operation
addressbook-level4 copied to clipboard

Commands with excess parameters should be parsed incorrectly

Open Zhiyuan-Amos opened this issue 7 years ago • 1 comments

Commands that do not require any parameters such as HelpCommand and ClearCommand will be parsed correctly even though the user input contains additional parameters e.g help 3, clear lalala.

As mentioned below, we should implement 'execute with warning' instead of 'reject'.

Zhiyuan-Amos avatar May 25 '17 00:05 Zhiyuan-Amos

Once we have the undo implemented, even destructive commands such as clear can be executed without the fear of irreversible damage, which means 'execute with warning' gives a better UX than 'reject' for cases like these.

damithc avatar May 25 '17 03:05 damithc