addressbook-level3 icon indicating copy to clipboard operation
addressbook-level3 copied to clipboard

Use jackson's `TypeReference` to deserialize into generic classes without warnings

Open TheMythologist opened this issue 2 months ago • 4 comments

Closes #241

TheMythologist avatar Oct 25 '25 06:10 TheMythologist

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] avatar Oct 25 '25 06:10 canihasreview[bot]

v1

@TheMythologist submitted v1 for review.

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/242/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

canihasreview[bot] avatar Oct 25 '25 06:10 canihasreview[bot]

Thanks for this PR, @TheMythologist We are likely to look into this after this semester is over. In the meantime, please submit a new version with a detailed commit message -- in AB3, we normally use a detailed commit message with a body (see https://se-education.org/guides/conventions/git.html)

damithc avatar Oct 26 '25 13:10 damithc

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 75.28%. Comparing base (bd6718b) to head (8168ef1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     75.26%   75.28%   +0.01%     
  Complexity      419      419              
============================================
  Files            71       71              
  Lines          1338     1339       +1     
  Branches        126      126              
============================================
+ Hits           1007     1008       +1     
  Misses          301      301              
  Partials         30       30              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 26 '25 13:10 codecov[bot]