addressbook-level3
addressbook-level3 copied to clipboard
Rebase tutorial-add-remark branch
Update add-remark branch by rebasing, to fix issues mentioned in in https://github.com/nus-cs2103-AY2425S1/forum/issues/460 Need to update https://se-education.org/guides/tutorials/ab3AddRemark.html as well
Hi prof @damithc I was trying to look into this, but I'm a little confused about the steps to take. For reference here are the 9 commits on the tutorial-add-remark branch:
Would it be correct to say we want to:
- rebase
tutorial-add-remarkto be ahead ofmasterso that we're using the most updated APIs from the rest of AB3 (in particular thePersonclass utility functions) and have a similar project structure (for the static import statement) - this would lead to some commits having outdated API calls. So for each of the 9 commits we manually update any code without losing the main learning point from each commit
- update URLs in the ab3addRemark guide to reference the new commits and if necessary the code blocks that appear in the guide
Would it be correct to say we want to:
1. rebase `tutorial-add-remark` to be ahead of `master` so that we're using the most updated APIs from the rest of AB3 (in particular the `Person` class utility functions) and have a similar project structure (for the static import statement) 2. this would lead to some commits having outdated API calls. So for each of the 9 commits we manually update any code without losing the main learning point from each commit 3. update URLs in the ab3addRemark guide to reference the new commits and if necessary the code blocks that appear in the guide
Yes. that's correct @drustanyjt
Got it, I'll work on a PR for this.