sdv-dev
Allow for disconnected tables
CU-86b092r53 Issue
Allow for disconnected schemas by removing the check.
Metadata visualization still works All other synthesizers work fine with no relationships defined in metadata (HMA and SDV Enterprise multi-table synthesizers) Evaluations and quality report still work (Eye test scores look fine, cardinality and intertable trends drop in score)
Does not require any other fixes for running multi-table synthesizer
Now that datacebo/sdv-enterprise#585, datacebo/sdv-enterprise#578, and datacebo/sdv-enterprise#579 are in can we re-run the experiments to make sure everything works as expected? @lajohn4747
Assuming everything works and no other issues arise, are we good to mark this as ready @npatki?
Now that https://github.com/datacebo/SDV-Enterprise/issues/585, https://github.com/datacebo/SDV-Enterprise/issues/578, and https://github.com/datacebo/SDV-Enterprise/issues/579 are in can we re-run the experiments to make sure everything works as expected? @lajohn4747
Validated it works for demo datasets for all our multi-synthesizers.
So if you run the tests on enterprise (including the benchmarking) with these updates everything passes?
Yep all the tests and benchmark tests pass
Can we add an integration test?
Added one for HMA. I also plan to add more tests in our other synthesizers as well as well: https://github.com/datacebo/SDV-Enterprise/pull/621
So if you run the tests on enterprise (including the benchmarking) with these updates everything passes?
Yep all the tests and benchmark tests pass
Just wanted to note that HMA benchmark leaves out a lot of datasets because they take a very long time for the larger datasets and diagnostic reports do not go over HMA at all.
@amontanez24 @npatki