SDV icon indicating copy to clipboard operation
SDV copied to clipboard

Use `AnonymizedFaker` for primary keys

Open fealho opened this issue 1 year ago • 4 comments

CU-86azdzv1n, Resolve #1807.

fealho avatar Mar 06 '24 16:03 fealho

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.32%. Comparing base (6222922) to head (d0da7c5). Report is 13 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          50       50           
  Lines        4821     4823    +2     
=======================================
+ Hits         4692     4694    +2     
  Misses        129      129           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 06 '24 17:03 codecov-commenter

Results of the change: Screenshot 2024-03-07 at 10 06 33 AM (2)

fealho avatar Mar 07 '24 18:03 fealho

Could we add a test for this as well?

I can't write a test which actually verifies the logic, since that requires SDV-Enterprise. I can add a unit test that runs through the logic though.

fealho avatar Mar 08 '24 14:03 fealho