CTGAN icon indicating copy to clipboard operation
CTGAN copied to clipboard
verified publisher icon sdv-dev

functions "generate_cond_from_condition_column_info" and "sample_original_condvec"

Open Hamideh-Mehri opened this issue 2 years ago • 1 comments

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • CTGAN version:
  • Python version:
  • Operating System:

Error Description

Hello,

I think that two functions "generate_cond_from_condition_column_info" and "sample_original_condvec" does not produce conditional vector correctly. the issue is " _discrete_column_matrix_st" which always contains zeroes, and is not assigned properly.

I would really appreciate it if let me know whether I am correct or not.

Steps to reproduce

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Hamideh-Mehri avatar Feb 25 '23 20:02 Hamideh-Mehri

Hi @Hamideh-Mehri, maybe you can look at my PR: https://github.com/sdv-dev/CTGAN/pull/236. I believe this fixes the issue.

AndresAlgaba avatar Feb 28 '23 13:02 AndresAlgaba