wifi-password
wifi-password copied to clipboard
sdushantha
List networks
This PR includes a set of changes to list saved networks (see item #28 ) on Windows, it also moves most functions into a utils.py file so they can be reused more efficiently.
Added comments to each function to understand what they do.
Please note that this changes are only made for Windows platform, it is pending to implement the changes for Linux and MacOS.
hi @sdushantha I implemented the changes request and made a couple of changes due to the latest versions such as rstrip being used in the run_command output
hi @sdushantha , @hez2010
Sorry to be inactive for some time, I have had some personal issues but now it's fine and I was able to take this back, I commited some changes to this PR and the tool seems to work fine for me, can you review it please?
Thanks!
@hez2010 Sorry about the delay on this issue. I'll be able to work on this issue sometime during the coming 2 weeks.
I don't think this PR should be merged yet. We can merge it once have added support for Linux and macOS.
I don't think this PR should be merged yet. We can merge it once have added support for Linux and macOS.
Sounds fair, I will try to get a VM for MacOS and I think Linux will be easier to cover, so let me get a chance to do that and I will update this PR with the proper changes, although I don't have much time right now :(, but will do my best of course.
Hi
I recently proposed to @pelonchasva an implementation of the list feature for MacOS and Linux that he accepted to add to his implementation.
I would like to reopen the pull request, do you have an opinion on my proposal?
