wifi-password icon indicating copy to clipboard operation
wifi-password copied to clipboard

This is awesome! I wonder if we can make it a brew formula!

Open mickeypash opened this issue 4 years ago • 6 comments

Found some details here: https://docs.brew.sh/Homebrew-and-Python

Let me know if you like the idea! I can have a look to see what it takes and raise a PR.

mickeypash avatar Jan 25 '21 22:01 mickeypash

Hi @mickeypash,

I'm glad that you liked this project!

Creating a brew formula would be great but we would encounter a conflict in the formula name as there already exists a formula named wifi-password. That formula belongs to this project: https://github.com/rauchg/wifi-password

I updated the README a couple of minutes ago:

This project is an improvement of wifi-password created by @rauchg, where I have added support for multiple platforms and have added the feature for generating QR codes.

Since we already have this project on PyPi and is installable through pip, I think it would be best to drop the idea of creating a brew formula because pip is multiplatform while brew is only for macOS.

Let me know what your thoughts are on this :)

sdushantha avatar Jan 26 '21 06:01 sdushantha

Oh that's great! Thanks for the clarification! I wonder if it's possible to claim that namespace wifi-password assuming it's backwards compatible with the existing one? The reason I suggested brew is I think there are many folk that prefer it as an interface to installing globally accessible packages. I personally tend to avoid pip installing anything in my user or system wide using pip as I'm worried about version conflicts.

mickeypash avatar Jan 26 '21 11:01 mickeypash

Yes, I too prefer to use the system's package manager.

I unfortunately do not have enough time to prioritize this, so would you like to have a go at creating a brew formula for this?

sdushantha avatar Jan 26 '21 11:01 sdushantha

I think you could also add something to the name of the formula (eg: wifi-password-utility or wifi-password-plus)

Samuel-Martineau avatar Jan 27 '21 12:01 Samuel-Martineau

while brew is only for macOS

Homebrew also works on Linux FYI: https://docs.brew.sh/Homebrew-on-Linux

This project won't be accepted in homebrew-core at that state, because it has less than 75 stars at the moment. You can consider creating a tap for it though: https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

Update: nvm, project has over 100 stars now, it could make its way to the core tap.

dawidd6 avatar Jan 27 '21 12:01 dawidd6

Having nix package would be awesome as well, as the other wifi-password has cc https://search.nixos.org/packages?channel=20.09&show=wifi-password&from=0&size=50&sort=relevance&query=wifi-password

blaadje avatar Jan 31 '21 14:01 blaadje