modest-py icon indicating copy to clipboard operation
modest-py copied to clipboard

ValueError when time is floating point in _select_lp

Open ozzdemir opened this issue 3 years ago • 1 comments

Hi, when I gave floating point time instances, random.randint() gives Value error. Is there a particular reason for using random.randint() instead of random.uniform() ? [I locally replaced it with random.uniform(), and it worked with floating time also].

https://github.com/sdu-cfei/modest-py/blob/d539a94449547f7e8b07dec617c82003bb2ce949/modestpy/estimation.py#L612

Note that I did not give lp_frame explicitly, so it took the time from "ideal". (If the choice is related to performance, maybe rounding can be made?)

Thanks in advance

ozzdemir avatar Jun 22 '21 10:06 ozzdemir