marvin icon indicating copy to clipboard operation
marvin copied to clipboard

the remote sasurl doesn't properly stick to local mode when switching to public release

Open havok2063 opened this issue 6 years ago • 2 comments

Describe the bug There is now a collab and public api url to the SAS. Setting the sasurl to local for development and then switching the release from MPL to a DR reverts the sasurl to the real remote one.

To Reproduce Steps to reproduce the behavior:

from marvin import config
config.release
'MPL-7'
config.switchSasUrl('local')
config.sasurl
'http://localhost:5000/marvin/'

config.setRelease('DR15')
config.sasurl
 'https://dr15.sdss.org/api/marvin/'

Expected behavior It would be good if we only needed to set the sasurl to local once, and it stays local as we switch releases.

Additional context This bug only affects developers and is arguably a low priority. We can currently get around it by running config.switchSasUrl('local') again, after every time we change releases.

havok2063 avatar Jul 27 '18 15:07 havok2063

This is not really a bug that users will deal with. This only affects developers trying to switch public and collaboration releases but still using a localhost development server. I think this can be closed and ignored.

havok2063 avatar Nov 20 '18 23:11 havok2063

Agreed.

albireox avatar Nov 21 '18 00:11 albireox