marvin icon indicating copy to clipboard operation
marvin copied to clipboard

Make Cube work with all versions of files

Open albireox opened this issue 7 years ago • 3 comments

The datamodel for Cubes is stable enough that there is probably no good reason to prevent opening a cube file from any version.This should be fairly easy to do. Right now we check whether the version of the file is in the lookup table, and fail if not. If we issue a warning instead of raising an error, I think everything else would work, although we would want to add some check to inform the user that no maps/modelcubes exist for that version if they try to open one.

This is related to #221 and #285.

albireox avatar Aug 08 '17 14:08 albireox

I think this should only be available when using the filename keyword argument.

havok2063 avatar Aug 09 '17 13:08 havok2063

Yes, because I don't think we are planning on loading cube from intermediate reductions, or any DR earlier than DR15, this should only work if you specifically ask to load that file.

albireox avatar Aug 09 '17 15:08 albireox

I just meant that we shouldn't make this useable via the plateifu or mangaid arguments. I think filename can be used for any cube version outside of an MPL or DR. It might not be too hard to make Marvin usable with DR13 and 14 cubes. We can just raise an error if they try to access any DAP things via it.

havok2063 avatar Aug 09 '17 17:08 havok2063