Rootex icon indicating copy to clipboard operation
Rootex copied to clipboard

Theme integration

Open SK1PPR opened this issue 8 months ago • 5 comments

SK1PPR avatar Apr 30 '25 18:04 SK1PPR

@twaritwaikar I have added a 3rd party header for reading the json files, for now placed it in the same directory only, but should I place it somewhere else? maybe make a 3rdparty folder. Also please review current changes

SK1PPR avatar May 01 '25 15:05 SK1PPR

@SK1PPR We already have a JSON library present here - https://github.com/sdslabs/Rootex/tree/dev/rootex%2Fvendor%2FJSON

You can try to find examples of how we use it and just do the same here

twaritwaikar avatar May 01 '25 15:05 twaritwaikar

You probably have the nholmann/json library in the scope. This is how it's utilized in types.h - https://github.com/sdslabs/Rootex/blob/dev/rootex%2Fcommon%2Ftypes.h#L158

types.h should be already included in the scope. If not, just add it and you will have the JSON namespace from there

twaritwaikar avatar May 01 '25 15:05 twaritwaikar

Clang-format 11 use ho raha in the gh-action, and currently 20 h isiliye failed aa raha, mai isko theek krne ka dekhta

SK1PPR avatar May 04 '25 10:05 SK1PPR

Ab toh nhi pata why it is failing clang-format ka test, mai isko ete baad dekhta

SK1PPR avatar May 04 '25 11:05 SK1PPR