page-transitions-travelapp icon indicating copy to clipboard operation
page-transitions-travelapp copied to clipboard

Profile photos are not visible but clickable

Open chrisbbreuer opened this issue 6 years ago • 4 comments

Hi there,

I found a little issue which is demonstrated in the gif below.

Bug

If I get the chance, I will check into it one of these days if no one beats me to it.

Any pointers on how you'd want it fixed, and I will eventually do it!

Thanks!

chrisbbreuer avatar May 05 '18 01:05 chrisbbreuer

Oh snap! Good call! Probably best thing is to completely remove them from the DOM until they are being used (I needed to do this for accessibility anyways). That could be accomplished with a v-if directive but there are several ways to do it.

sdras avatar May 05 '18 01:05 sdras

I assumed so. I will send in a PR soon if no one has before me

chrisbbreuer avatar May 05 '18 01:05 chrisbbreuer

Thanks!

sdras avatar May 05 '18 01:05 sdras

@sdras I am rather unfamiliar with transitions still, but I am trying to learn, so here's my approach: https://github.com/Chris1904/page-transitions-travelapp/commit/d02c27b118197aa24463a82a8b9983dde5bba2cf

The issue, though, is that when switching back and forth from places to group trips, .profile-0 is not transitioned correctly. I will try to work on it a little longer to figure it out myself, but any pointers would be great.

chrisbbreuer avatar May 08 '18 01:05 chrisbbreuer