night-owl-vscode-theme icon indicating copy to clipboard operation
night-owl-vscode-theme copied to clipboard

2.0 isn't coloring/dinstinctint template literals from strings

Open JavierPiedra opened this issue 4 years ago • 6 comments

image

JavierPiedra avatar Oct 15 '20 03:10 JavierPiedra

well, hm... someone else asked that they be the same color. I have to think of what to do now. I think I agree with you, let me use the new version a bit and see.

sdras avatar Oct 18 '20 00:10 sdras

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

ivansvlv avatar Nov 03 '20 18:11 ivansvlv

Do you think it's necessary or useful to colour them differently? Template literal produces a string so it's quite intuitive to consider it as a string. Besides, template literals usual usage is to interpolate values into the string, and I would argue that Night Owl has one of the best interpolation highlighting, thus making it pretty obvious what are you working with.

Yes, it has been useful to me, specially to find it quickly. I notice the change.

JavierPiedra avatar Nov 03 '20 18:11 JavierPiedra

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Screen Shot 2020-11-25 at 10 19 42

selensr avatar Nov 25 '20 07:11 selensr

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes.

Screen Shot 2020-11-25 at 10 19 42

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

ivansvlv avatar Nov 25 '20 07:11 ivansvlv

This was really useful. I'd like to see that template literal coloring again. Actually, HTML tag and component colors are also changing to some green. It became really hard for reading and for eyes. Screen Shot 2020-11-25 at 10 19 42

Do you have this extension installed? - https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel

If yes, it might be causing your component colouring change.

Yes, it is indeed. Thank you a lot. Tags and texts back to normal.

selensr avatar Nov 25 '20 07:11 selensr