night-owl-vscode-theme icon indicating copy to clipboard operation
night-owl-vscode-theme copied to clipboard

Inconsistent "const" color in TypeScript inside class

Open alexluong opened this issue 5 years ago • 7 comments

Hi,

I recently started working with TypeScript, and I noticed that there is some inconsistency with const color when used inside classes.

Screen Shot 2019-10-16 at 10 12 14 PM

alexluong avatar Oct 17 '19 03:10 alexluong

Hit a similar issue - to further illustrate, compare "payload" and "params" in Nightowl (first screenshot) and the standard vscode dark theme (second screenshot):

image

image

Obviously night owl looks better :) - but "payload" should be consistently white

cjke avatar Jan 13 '20 12:01 cjke

It's not that payload should be always white- it's that the const within classes should be pink as it is outside of a class:

image

MrDrummer avatar Mar 10 '20 19:03 MrDrummer

@MrDrummer You're right, but I think both are issues (arguably I could've raised a separate issue)

cjke avatar Mar 10 '20 22:03 cjke

Have you tried to set your settings:

"editor.semanticHighlighting.enabled": false

jvbianchi avatar Mar 12 '20 19:03 jvbianchi

I should note that it seems to work fine on my linux laptop at work. I freqently keep my work laptop and personal windows PC's settings in sync using an extension that uses a private gist to store the settings, extensions and snippets.

Adding the setting you suggested and reloading code didn't change anything.

MrDrummer avatar Mar 12 '20 19:03 MrDrummer

I have the same issues with classes. I'd love to help debugging this, but I'm not quite sure how. IC4InI4

duerdod avatar Apr 27 '20 19:04 duerdod

I published a PR that fixes this issue, please feel free to take a look if you need a fix for this! I have a packaged VSIX extension file available here if you want to install it directly.

Screen Shot 2020-06-08 at 12 11 54 PM

sfred avatar Jun 08 '20 16:06 sfred