night-owl-vscode-theme icon indicating copy to clipboard operation
night-owl-vscode-theme copied to clipboard

Published 20 hours ago • verified publisher icon sdras

CSS Custom Props (css variables) syntax highlighting

Open chiangs opened this issue 5 years ago • 6 comments

I would like to request a little more distinction in the syntax highlighting for css variables. code

chiangs avatar Jul 03 '19 11:07 chiangs

Definitely! This should be more legible. I'm happy to work on this but I'm low on time, so if I do it, it won't be for a couple of months. Open to PRs.

sdras avatar Sep 16 '19 14:09 sdras

I've been searching for a good reference on how to select these in the settings, but I am struggling to figure it out using TextMates' documentation. Can you share the source you referenced in building this theme? Thanks!

chiangs avatar Sep 25 '19 00:09 chiangs

@sdras I've got it working now, here is the regular dark theme, can you comment before i move on to the other themes?

I've opted for the purple color you used and also set it to italic when actually being used and non-italic when just being declared.

Also could you tag this as assigned to me and in progress?

code

here's another color option

code

chiangs avatar Oct 02 '19 13:10 chiangs

@chiangs That looks really good, maybe I like the second option more. Are you working on fixing this issue? If not I would't mind taking a look.

Niroa95 avatar Oct 04 '19 11:10 Niroa95

@Arnau-Ninerola Yes I am actively working on it, I just wanted @sdras to have a look first and assign to me. I think I like the second one better as well.

chiangs avatar Oct 04 '19 11:10 chiangs

@sdras PR opened

chiangs avatar Oct 07 '19 11:10 chiangs