night-owl-vscode-theme icon indicating copy to clipboard operation
night-owl-vscode-theme copied to clipboard

Request: Light theme tweaks

Open cdeutsch opened this issue 5 years ago • 2 comments

I love the Dark mode of Night Owl and it's my primary theme!

In certain lighting conditions I've been looking for a Light theme, and Night Owl Light (No Italics) is pretty close.

Here are some things I've been tweaking for what it's worth.

I can do a PR for some of this if you're interested.

- Active tab is hard to distinguish

image

Adjusted to #fefefe

image

- Selected text in "Find in Files" is hard to read

image

Adjusted to #c2c7c78f

image

Syntax highlighting contrast ratios aren't as high as Dark mode

Dark = 7.62 https://contrast-ratio.com/#%23c792ea-on-%23011627

Light = 4.85 https://contrast-ratio.com/#%23994cc3-on-%23fbfbfb

To increase the ratio I changed all of the #994cc3 TextMate rules to #7c11b7 which has a 7.7 ratio https://contrast-ratio.com/#%237c11b7-on-%23fbfbfb

And the #c789d6 for JSON Property values (string) to #b63dd4.

Haven't gone any further yet, because I'm not great at picking colors.

Thanks for bringing this theme into the world!

cdeutsch avatar Jun 20 '19 13:06 cdeutsch

@cdeutsch I was having the same problem with the active tab contrast. Your fix is great! Thanks!

aualdrich avatar Jan 21 '21 15:01 aualdrich

I've found this combination, when combined with @cdeutsch's active tab color, gives a really nice tab appearance:

    "[Night Owl Light]": {
      "tab.activeBackground": "#fefefe",
      "tab.activeBorder": "#994cc3"
    }

aualdrich avatar Jan 21 '21 15:01 aualdrich