array-explorer icon indicating copy to clipboard operation
array-explorer copied to clipboard

reduceRight wrong example?

Open alizhdanov opened this issue 6 years ago • 3 comments

Hello, I'm not sure, but in find items -> one item:

reduce returns sum of the array, as I'd expect, while reduceRight 'flatten' arrays. Shouldn't it be also sum?

alizhdanov avatar Sep 03 '18 22:09 alizhdanov

They're using different demo functions, and their return values are consistent with those functions. Returning the sum is just a common example use case for [].reduce.

[].reduce starts at the beginning of the array and works its way to the end. [].reduceRight starts at the end and works its way to the beginning. I think the example for [].reduceRight used in the pen might be mildly confusing for those still learning since it reduces nested arrays. Here's an example of both using the same function; note how the output differs:

['a', 'b', 'c', 'd'].reduce((current, carry) => current+carry); // ➡ abcd
['a', 'b', 'c', 'd'].reduceRight((current, carry) => current+carry); // ➡ dcba

QWp6t avatar Nov 12 '18 22:11 QWp6t

Yeah @QWp6t you're right, I should make that a little more clear and easy to understand for beginners, since that's who this resource is for.

sdras avatar Nov 13 '18 01:11 sdras

@sdras - hello! Can I work on this issue? 🙂

rimildeyjsr avatar Oct 02 '19 11:10 rimildeyjsr