openNetVM icon indicating copy to clipboard operation
openNetVM copied to clipboard

JSON load balancer config file

Open andreaseno opened this issue 2 years ago • 2 comments

Replaced the server.conf file inside the load balancer nf with a json file called server.json. Because the config file parser was written for a plaintext file rather than a json file, I had to rewrite the backend config file parse function. It now uses cjson to parse the config file.

Summary:

Usage:

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements
Bug fixes
New functionality x
New NF/onvm_mgr args
Changes to starting NFs x
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: Should be merged after pull request #327 for the weighted policy, since this code includes code from that pull request.

TODO before merging :

  • [x] PR is ready for review

Test Plan:

I tested the changes by doing a full setup of a 2 server ONVM experiment, made sure the arp_response and load balancer nf's ran correctly without error, and used iperf to verify that the packets would still send correctly. The only other necessary testing I can think of off the top of my head is verifying it works with more than 2 servers.

Review:

(optional) << @-mention people who should review these changes >>

(optional) Subscribers: << @-mention people who probably care about these changes >>

andreaseno avatar Jul 26 '22 18:07 andreaseno

@andreaseno I merged #327 so now you will need to resolve conflicts.

twood02 avatar Aug 04 '22 19:08 twood02

@andreaseno @xwedea I added a couple more changes. If you can fix them sometime in the next few weeks - great! If not I'll get another student to help out later.

twood02 avatar Aug 21 '22 22:08 twood02