Sébastien Deleuze

Results 602 comments of Sébastien Deleuze
trafficstars

If possible, I would like to move forward on this issue for 2.1 by providing a PR implementing [this improvement](https://github.com/spring-projects/spring-boot/issues/8115#issuecomment-341142917) if we can come to an agreement about what needs...

After more thoughts and discussions on that topic, I think I have changed my mind and agree with @snicoll about the fact that adding more functional bean definition support to...

My feedback from Spring POV: - Include all resources from program JARs: we tried that and it does not work well in practice without a big list of exception because...

See my recent comment on log4j2 native support [here](https://issues.apache.org/jira/browse/LOG4J2-2649?focusedCommentId=17610488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17610488).

Related to that, I think the workflow for source-based deployment is already ok, but it may potentially be interesting to explore first class options to create native executable from a...

Notice Spring Framework reference documentation mentions: > `@Profile`, in particular profile-specific configuration needs to be chosen at build time I think this is consistent with the refinement proposed in this...

As shown in https://github.com/sdeleuze/demo-profile-aot, based on @snicoll insights I figured out we already support defining Spring profile AOT, it was just not easy to figure out based on the documentation....

The change of behavior seems to have been introduced in Spring Framework 6.1: - With Spring Boot 3.1, `params` contains both the ones defines in query parameters and request body...

In `AbstractMessageConverterMethodArgumentResolver#readWithMessageConverters`: Spring Boot `3.1.12` `((ServletServerHttpRequest)inputMessage).getBody()` is a `ByteArrayInputStream` `((ServletServerHttpRequest)inputMessage).getBody().readAllBytes()` returns 22 bytes as expected. Spring Boot `3.2.8` `((ServletServerHttpRequest)inputMessage).getBody()` returns a `CoyoteInputStream` `((ServletServerHttpRequest)inputMessage).getBody().readAllBytes()` returns 0 bytes Both uses Tomcat 10.1.x.

Likely a regression caused by gh-31327 (via 8fa428f825323d6bc0d3051ad44d84a249fcaf39) as you have already found @membersound (could have been nice to mention it in the issue description, please share all your findings...