lets-chat
lets-chat copied to clipboard
sdelements
Add SSO auth support
This is pretty feature complete. I'm looking for some feedback. I've been testing with local, gitlab, github and google simultaneously. XMPP with token based auth to circumvent lack of passwords. LDAP and kerberos plugins would need to be updated as well.
More verbose description here: #315
Auth plugins: https://github.com/dyerti/lets-chat-gitlab https://github.com/dyerti/lets-chat-github https://github.com/dyerti/lets-chat-google
The plugins work, but are definitely not final. Name vs First/Last name and possible lack of email standout. Generation of a unique identifier that shouldn't collide cross auth environment. I'm thinking base64(md5(url + site specific id)).
- Rebased to the new release.
- Added i18n to new content
I know this is currently backlogged, but any feedback or interest for this functionality in the next release?
Hi @dyerti, sorry we haven't looked at this PR yet - we were focused on getting 0.4 merged. Will start taking a look at this soon!
Hi, @dyerti thanks for this PR, i've been waiting for Google SSO support for a while :+1:
Hey @dyerti, thanks for the help getting the google plugin installed on my server
your code is good. I hacked it up and made a twitter plugin that's functional.
https://github.com/8bitjeremy/lets-chat-twitter
The no-lastname error check in Let's Chat screws it up along with duplicate Social accounts touching the same user (email?). I think that user profiles may need to be expanded to allow for multiple SSO social accounts. Thoughts?
I'm no longer using Let's Chat, so I'm not going to be pushing things from my end. If someone wants to pick it up that would be awesome.