sddm icon indicating copy to clipboard operation
sddm copied to clipboard

SIGHUP reload support

Open aanderse opened this issue 9 months ago • 7 comments

i did a search for SIGHUP in the project and found a few references - it looks to me that sddm intended to support reload on SIGHUP, at least at one point...

currently if i send this signal my entire desktop session ends and sddm restarts - looking through the code i can't see explicit support for reloading anymore and possibly the code that did support it was (accidentally?) removed in a refactor at one point?

is anyone able to comment on whether sddm is supposed to support reload on SIGHUP or not?

thank you

aanderse avatar Mar 23 '25 12:03 aanderse

currently if i send this signal my entire desktop session ends and sddm restarts - looking through the code i can't see explicit support for reloading anymore and possibly the code that did support it was (accidentally?) removed in a refactor at one point?

Same.

is anyone able to comment on whether sddm is supposed to support reload on SIGHUP or not?

At least since da6719197ac68d1fe727f99baf3c4e764816b534 it's supposed to just ignore SIGHUP. If it quits, something isn't quite right. Maybe it needs to be blocked explicitly.

Vogtinator avatar Mar 23 '25 13:03 Vogtinator

is anyone able to comment on whether sddm is supposed to support reload on SIGHUP or not?

We already reload if you logout before we show the greeter again, so I can't see what use-case there would be for manually reloading.

davidedmundson avatar Mar 23 '25 15:03 davidedmundson

i am playing with an init system that sends a SIGHUP to every monitored process on the systemd equivalent of systemctl daemon-reload - this kills my session with sddm

so i am looking for a display manager which reloads on SIGHUP - i saw that sddm used to so i thought i would ask

aanderse avatar Mar 23 '25 15:03 aanderse

i am playing with an init system that sends a SIGHUP to every monitored process on the systemd equivalent of systemctl daemon-reload - this kills my session with sddm

If your init system just sends SIGHUP unconditionally it's IMO just broken.

Vogtinator avatar Mar 23 '25 20:03 Vogtinator

We already reload if you logout before we show the greeter again, so I can't see what use-case there would be for manually reloading.

ok, i'll take that as confirmation there is no reason to add this functionality back? if so then it makes sense to close this issue as the question has been answered.

thanks both for your time 🙇

aanderse avatar Mar 23 '25 20:03 aanderse

IMO there's at least a bug left: SIGHUP just just be ignored, not cause SDDM to quit or restart.

Vogtinator avatar Mar 23 '25 20:03 Vogtinator

ok - will leave open since there is intention to address or at least acknowledge 👍

aanderse avatar Mar 23 '25 20:03 aanderse