techan
techan copied to clipboard
Represent TimeSeries as an interface
Hi there!
I've converted TimeSeries from struct to interface, more alike to ta4j. I think it's beneficial because TS can be implemented differently, using Influxdb for example.
Codecov Report
Merging #14 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 553 560 +7
=====================================
+ Hits 553 560 +7
Impacted Files | Coverage Δ | |
---|---|---|
indicator_relative_vigor_index.go | 100% <100%> (ø) |
:arrow_up: |
indicator_basic.go | 100% <100%> (ø) |
:arrow_up: |
testutils.go | 100% <100%> (ø) |
:arrow_up: |
timeseries.go | 100% <100%> (ø) |
:arrow_up: |
rule_stop.go | 100% <100%> (ø) |
:arrow_up: |
analysis.go | 100% <100%> (ø) |
:arrow_up: |
indicator_cci.go | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 35e5bd2...7b3e45d. Read the comment docs.
Any reason @sdcoffey why you havent merged this one? Looks good to me.
Hey guys, sorry for the delay here, for some reason there's an issue with my github settings that causes me to not get notifications about new PRs on this repo.