techan icon indicating copy to clipboard operation
techan copied to clipboard

Represent TimeSeries as an interface

Open andviro opened this issue 5 years ago • 3 comments

Hi there!

I've converted TimeSeries from struct to interface, more alike to ta4j. I think it's beneficial because TS can be implemented differently, using Influxdb for example.

andviro avatar Sep 25 '19 21:09 andviro

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         553    560    +7     
=====================================
+ Hits          553    560    +7
Impacted Files Coverage Δ
indicator_relative_vigor_index.go 100% <100%> (ø) :arrow_up:
indicator_basic.go 100% <100%> (ø) :arrow_up:
testutils.go 100% <100%> (ø) :arrow_up:
timeseries.go 100% <100%> (ø) :arrow_up:
rule_stop.go 100% <100%> (ø) :arrow_up:
analysis.go 100% <100%> (ø) :arrow_up:
indicator_cci.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35e5bd2...7b3e45d. Read the comment docs.

codecov[bot] avatar Sep 25 '19 21:09 codecov[bot]

Any reason @sdcoffey why you havent merged this one? Looks good to me.

utx0 avatar Oct 12 '19 05:10 utx0

Hey guys, sorry for the delay here, for some reason there's an issue with my github settings that causes me to not get notifications about new PRs on this repo.

sdcoffey avatar Oct 12 '19 13:10 sdcoffey