NeuralAmpModelerPlugin icon indicating copy to clipboard operation
NeuralAmpModelerPlugin copied to clipboard

Published 20 hours ago • verified publisher icon sdatkinson

Add NAM-specific app wrapper

Open olilarkin opened this issue 8 months ago • 3 comments

This PR takes the iPlug2 APP wrapper code and duplicates it into /app, updating the Xcode and Visual Studio projects to use the NAM-specific code. This means that someone can fix e.g. #157 without having to fix the code in iPlug2 (which needs a more thorough reworking for flexible multichannel support).

It may also be necessary to do the same thing for IPlugAPP.h and IPlugAPP.cpp but I don't think so.

olilarkin avatar Mar 16 '25 15:03 olilarkin

Thanks @olilarkin!

An alternative I see would be to go on a fork of the iPlug2 repo and make changes there. The main advantage is that the version control would have better continuity--this PR has lots of "green" which makes it hard to understand what the changes are (Can you lmk if there are any? Or is this just a copy-paste? Otherwise I'll have a look & diff it myself). I imagine that a similar issue would happen in the future if/when we merge back up?

Lmk your thoughts.

sdatkinson avatar Mar 16 '25 19:03 sdatkinson

It’s just a copy paste from the iPlug2/IPlug/App folder that is the code currently used by v0.7.3

its up to you… the app wrapper code is just code to host an IPlugApp … if i manage to land a much better app wrapper it shouldn’t be hard to switch back to use that

olilarkin avatar Mar 16 '25 21:03 olilarkin

I like the motivation for #157, so I'm going to go ahead and try to get this merged after I ship the next release (trying to finish that up asap)

sdatkinson avatar Jul 17 '25 21:07 sdatkinson