sdatkinson
[FEATURE] Use `"name"` in metadata to populate model name string
As a concrete first step sort of in line with #225, I'm putting this here.
If the "name" field exists inside the "metadata" of the .nam file, then use it to populate the display field :)
@sdatkinson I am interested to work on this issue. Could you please provide me with more information about this issue?
[Note: Seems like a fair amount of this may change after #242 gets in. Specifically, getting a handle of NeuralAmpModelerControls.h looks like the key. Might be best to hang tight for a moment. Advice for as it is now is below. Just lmk what you think.]
@tarunsamanta2k20 as of right now, here's the function that sets the string that's displayed: https://github.com/sdatkinson/NeuralAmpModelerPlugin/blob/main/NeuralAmpModeler/NeuralAmpModeler.h#L86
Currently, the model is loaded using get_dsp, providing a filename as input (here). Thanks to this PR on NeuralAmpModelerCore, you can keep the information about the model in a dspData struct.
Perhaps an instance of this struct could be owned by the NeuralAmpModeler instance, and it could be accessed during _SetModelMsg() to get the required information (if it's available). To do this, you'd use one of the other interfaces for get_dsp that's declared in the dsp.h header I referenced above (i.e. this one).
In order to do this, you'll need to bump forward the submodule commit that we're using to the latest from NeuralAmpModelerCore:main (since that PR was just merged the other day).
Lmk if this makes sense. There's a number of moving parts involved, but I'm happy to let you take a crack at it 🙂
