Simon Dassow
Simon Dassow
As I've been polishing this code I could not resist taking this into account, hence my attempt at it using option funcs above, based on earlier work in #20. It's...
Was actually expecting a suggestion or at least a comment with regard to testing, as that's an interesting aspect. In respect to changing the return type, I wonder if it...
Now after renaming the option from `FileMode` to `DefaultFileMode`, it would be possible to add a FileMode option with the same semantics a FileMode in the function signature would have...
Somehow the reference to the new solution in #18 is missing, hence this comment to add it.
Turns out those are two issues after all, my bad. The one about the link is indeed fixed in develop. Going to change the description so that it's only about...
Just checked and it does work correctly on macOS.
I've been trying to find a way to register only that without success. And I think the corresponding code always ignores custom shortcuts in favor of the predefined ones: https://github.com/fyne-io/fyne/blob/master/internal/driver/glfw/window.go#L867...
While building a Material Design Icon viewer using Fyne I ran into the same issue with all 7447 icons. None of them have CSS or other weird stuff in them....
After my comment I started comparing the example SVG with how the SVGs in my other project look like, and I could make it work by adding width and height...
Makes absolute sense to me and looks good as well.