CodeFormer icon indicating copy to clipboard operation
CodeFormer copied to clipboard

Incorrect positional embedding in Stage II.

Open Roller44 opened this issue 2 years ago • 0 comments
trafficstars

image

As shown in the figure above, the authors claimed they adopted the sinusoidal positional embedding in their project. However, as shown in the code below, they use "nn.Parameter" instead.

https://github.com/sczhou/CodeFormer/blob/8392d0334956108ab53d9439c4b9fc9c4af0d66d/basicsr/archs/codeformer_arch.py#L182

Roller44 avatar Nov 10 '23 08:11 Roller44