README file for Ubuntu did not mention invocation of the 'ninja' comm…

[sanjosh]

…and.

Added this line

[sanjosh]

This problem was raised on the mailing list as well https://groups.google.com/d/msg/seastar-dev/_wYMbdJIlrg/nJCb-W_FDQAJ

[nyh]

Hi, please send patches to the mailing list, not as github "pull requests", to allow everyone to participate in the review process.

This part of the README.md definitely needs to be fixed, but your fix is incomplete... It leaves the irrelevant instruction on how to supposedly "compile OSv" (which is completely irrelevant here).

BTW, it seems much of these instructions are outdated, not mentioning newer distributions...

Nadav Har'El [email protected]

On Tue, Nov 3, 2015 at 9:14 AM, sanjosh [email protected] wrote:

…and.

Added this line

You can view, comment on, or merge this pull request online at:

https://github.com/scylladb/seastar/pull/72 Commit Summary

• README file for Ubuntu did not mention invocation of the 'ninja' command.

File Changes

• M README.md https://github.com/scylladb/seastar/pull/72/files#diff-0 (5)

Patch Links:

• https://github.com/scylladb/seastar/pull/72.patch
• https://github.com/scylladb/seastar/pull/72.diff

— Reply to this email directly or view it on GitHub https://github.com/scylladb/seastar/pull/72.