seastar icon indicating copy to clipboard operation
seastar copied to clipboard

docs: show a coroutine-based implementation of the echo server in the tutorial

Open Dobiasd opened this issue 10 months ago • 5 comments

Hi,

this pull request is meant mainly as a proposal. For me, it was eye-opening to convert the continuation-based implementation of the TCP-echo server to coroutines. So I thought seeing this might help others too. But I don't know if it makes sense to have it in the tutorial. So, if you don't see fit, I'd fully understand if you simply close this PR without merging. :relaxed:

Dobiasd avatar Apr 02 '24 13:04 Dobiasd

/cc @nyh

avikivity avatar Apr 02 '24 14:04 avikivity

If you have any suggestions on what I can do to help move this PR forward, please let me know. In case it's currently not wanted, and you'd prefer to close this unmerged, that's also ok for me. :relaxed:

Dobiasd avatar May 19 '24 13:05 Dobiasd

If you have any suggestions on what I can do to help move this PR forward, please let me know. In case it's currently not wanted, and you'd prefer to close this unmerged, that's also ok for me. ☺️

Replace the continuations based example with the coroutine. There's no reason to show both.

avikivity avatar May 19 '24 18:05 avikivity

Thanks! I just did that in this commit which also adjusts the explanation text accordingly. :heavy_check_mark:

Dobiasd avatar May 20 '24 06:05 Dobiasd

If there is any way I can help move this forward, please let me know.

Dobiasd avatar Jul 02 '24 07:07 Dobiasd