scylladb
scripts: use dpdk-devbind.py in dpdk submodule
instead of using the vendored dpdk-devbind.py script, use the one in the dpdk submodule. which is python3 compatible, and its command line usage is identical to the one being removed in this change.
But isn't it the same script as in the existing dpdk submodule? I mean -- dpdk/usertools/dpdk-devbind.py one. If so, why having a separate copy of it?
no, it's not. this is a sad story. we once bumped up the dpdk to a more recent version (see 76c87384dc8866aae603a4b598ff0adc8c9bac5a) which had a dpdk-devbind.py, and that version supported python3. but that change was later reverted (see 225bee3e38b2bbeb3b7507e8ac1f2b946c6b34ca). so at this moment, we have to stick with a dpdk in python2 era. and the script in the dpdk submodule only supports python2.
if what you suggest is to have the one from the submodule just because it has less repeatings. then i agree. but this does not address the problem addressed by this change.
now that we updated the dpdk submodule, we have the luxury of using its tools without vendoring it in the parent project.