scylladb icon indicating copy to clipboard operation
scylladb copied to clipboard

Storage Proxy: Maintain metrics in response handler classes

Open eliransin opened this issue 4 years ago • 3 comments

There is a known problem introduced by 971711a, the problem is that when some callbacks for a created response handler are called from another scheduling groups an imbalance is introduced to statistics which are now instantiated per scheduling group. This can be easily solved by "remembering" the stats of the scheduling group where the response handler was created. This will mask out another problem where certain operations are done outside of the "native" scheduling group. This is a complex issue that needs to be addressed in separate commit (see 971711a commit message).

Fixes #5797

eliransin avatar Aug 13 '20 07:08 eliransin

An older version of the patch have already been reviewed by @gleb-cloudius and @psarna , the patch title in the mailing list is: [PATCH] Storage Proxy: Maintain metrics in response handler classes The main change since the older patch is the introduction of paxos_executor and paxos stats to the structure.

eliransin avatar Aug 13 '20 07:08 eliransin

@eliransin / @psarna / @gleb-cloudius is this till relevant if so lets review / merge

slivne avatar Nov 04 '20 16:11 slivne

We will need this fix. @gleb-cloudius can you review?

eliransin avatar Nov 09 '20 13:11 eliransin

This was done already

eliransin avatar Oct 26 '23 08:10 eliransin