scylladb
scylladb copied to clipboard
scylladb
config: disable "mc" format sstables for new data
"md" format was introduced in 4.3, in 3530e80ce10fc20b, two years ago. Disable the option to create new sstables with the "mc" format.
v2: have feature service not disable the "mc" cluster feature with now-impossible config option.
@avikivity you only changed the config where is the change in the code that actually reads this config value ?
There's also the flag enable_sstables_mc_format, which is already marked "deprecated" but appears to have been worse than deprecated (it seems to have been ignored?) and should probably be removed.
docs/architecture/sstable/sstable3/index.rst also contains some out of date mentions of the mc format, but I guess this can/should be fixed separately.
@avikivity you only changed the config where is the change in the code that actually reads this config value ?
https://github.com/scylladb/scylladb/blob/8ee5b69f800481e31ecefbeae74d224d3d082152/gms/feature_service.cc#L32
There's also the flag
enable_sstables_mc_format, which is already marked "deprecated" but appears to have been worse than deprecated (it seems to have been ignored?) and should probably be removed.docs/architecture/sstable/sstable3/index.rst also contains some out of date mentions of the mc format, but I guess this can/should be fixed separately.
What needs to be fixed there? We still support mc. We just don't support disabling md and me.
CI state SUCCESS - https://jenkins.scylladb.com/job/releng/job/Scylla-CI/1763/
