scylla-tools-java icon indicating copy to clipboard operation
scylla-tools-java copied to clipboard

Published 20 hours ago • verified publisher icon scylladb

dist: drop Java tools and change packaging just for cassandra-stress

Open syuu1228 opened this issue 11 months ago • 7 comments

Since Java based tools are deprecated and now we only need cassandra-stress, change package name to "scylla-cassandra-stress" and drop deprecated tools from the package.

Closes #370

syuu1228 avatar Mar 22 '24 00:03 syuu1228

I think https://github.com/scylladb/scylla-ccm/pull/565 has to go in, before we can merge this.

denesb avatar Mar 22 '24 07:03 denesb

I think scylladb/scylla-ccm#565 has to go in, before we can merge this.

@denesb It was merged yesterday, can we merge this one?

yaronkaikov avatar Apr 03 '24 04:04 yaronkaikov

I think scylladb/scylla-ccm#565 has to go in, before we can merge this.

@denesb It was merged yesterday, can we merge this one?

Not yet. The above PR was reduced in scope to just prepare ccm for the post JMX world. Throwing out all of Java on on go proved too big of a bite, to chew at once.

I just realized we also didn't yet finish https://github.com/scylladb/scylladb/issues/14856, notably, there are still dtests around testing the java tools. These need to be either:

  • Dropped altogether, if we decided we don't want/need a native replacement for the tested tool (e.g. sstableutil).
  • Rewrite the test to test the native variant. We are still lacking native variant to some of these (small ones but still).

denesb avatar Apr 03 '24 06:04 denesb

Rebased, since it was conflicted.

syuu1228 avatar May 22 '24 18:05 syuu1228

I need to modify Obsoletes/Breaks/Replaces on this patch, since I supposed next release version is 5.5 so I wrote something like Replaces: %{product}-tools (<< 5.5) in this patch, but now we already released 6.0.

syuu1228 avatar May 27 '24 09:05 syuu1228

Replaced << 5.5 with << 6.1.

syuu1228 avatar May 27 '24 10:05 syuu1228

I think this one is not needed and this task https://github.com/scylladb/scylla-tools-java/issues/370 misled you.

We can/should keep the packaging as "scylla-tools-java" and c-s will be part of it. There is no need to separate it now after we separated it from Scylla.

So, the packaging can remain as scylla-tools-java but just not a dependency of scylladb.

roydahan avatar Jun 30 '24 10:06 roydahan