scylla-tools-java icon indicating copy to clipboard operation
scylla-tools-java copied to clipboard
verified publisher icon scylladb

bin/nodetool-wrapper: always forward help to java-nodetool

Open denesb opened this issue 2 years ago • 5 comments

Since scylla-nodetool already implements "help", nodetool help is routed to it. This results in command not yet implemented by scylla-nodetool getting an error, when one tries to get help for them. To avoid this, always forward help commands to the java nodetool.

Fixes: scylladb/scylladb#16669

denesb avatar Jan 09 '24 08:01 denesb

Don't merge yet, v2 is coming.

denesb avatar Jan 09 '24 11:01 denesb

Don't merge yet, v2 is coming.

Scrap that, this PR is good to go as-is.

denesb avatar Jan 09 '24 11:01 denesb

might want to link to https://github.com/scylladb/scylladb/issues/16669 with the full path or use scylladb/scylladb#16669 instead of #16669 .

tchaikov avatar Jan 11 '24 10:01 tchaikov

might want to link to scylladb/scylladb#16669 with the full path or use scylladb/scylladb#16669 instead of #16669 .

Fixed.

denesb avatar Jan 11 '24 11:01 denesb

@scylladb/scylla-maint hello maintainers, could you help review and merge this change?

tchaikov avatar Feb 09 '24 02:02 tchaikov

This has aged out, closing.

denesb avatar May 22 '24 04:05 denesb