scylla-rust-driver icon indicating copy to clipboard operation
scylla-rust-driver copied to clipboard

[.github/workflow/rust.yml] Add docker credentials to avoid rate limit

Open yaronkaikov opened this issue 1 year ago • 4 comments
trafficstars

To avoid errors such

Error toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

we should add a login to our Scylladb docker hub

Adding it

yaronkaikov avatar Oct 14 '24 19:10 yaronkaikov

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳 Checked commit: 8d9993b18e4089513e4dce901468a0dc623e86fa

github-actions[bot] avatar Oct 14 '24 19:10 github-actions[bot]

Thanks!

Could you update other jobs too? Those also use docker:

authenticate_test.yml
book.yml
cassandra.yml
tls.yml

Lorak-mmk avatar Oct 15 '24 14:10 Lorak-mmk

Thanks!

Could you update other jobs too? Those also use docker:

authenticate_test.yml
book.yml
cassandra.yml
tls.yml

Added

yaronkaikov avatar Oct 15 '24 14:10 yaronkaikov

@Lorak-mmk Address all comments , please review again

yaronkaikov avatar Oct 20 '24 05:10 yaronkaikov

@yaronkaikov What's the status of this?

wprzytula avatar Apr 14 '25 10:04 wprzytula

@yaronkaikov What's the status of this?

Wow, completely forgot about this one. I need to find the time to get back to this

Do we see the original error ?

yaronkaikov avatar May 07 '25 04:05 yaronkaikov

Do we see the original error ?

I've never seen it. @Lorak-mmk?

wprzytula avatar May 07 '25 05:05 wprzytula

I have not seen it since.

I'm ok with finishing this PR and merging, and also with closing it since the error did not happen again.

Lorak-mmk avatar May 07 '25 06:05 Lorak-mmk

I have not seen it since.

I'm ok with finishing this PR and merging, and also with closing it since the error did not happen again.

Closing for now

yaronkaikov avatar Sep 21 '25 15:09 yaronkaikov