scylla-operator
scylla-operator copied to clipboard
scylladb
Evaluate special 'now' terms in Scylla Manager tasks only on task creation
Special 'now' value was evaluated on every ScyllaCluster reconcilation. Because it's result is always different, task definition was always different than the same task stored in Manager state. Hence every task was constantly updated with newer startDate.
Fixes #838
- pls update the CRD description accordingly
done
- shouldn't you set creationTimestamp on task create - it can be arbitrarily delayed
startDate cannot be in the past, so it's evaluated at reconcilation when task is about to be created with some extra buffer (30s) for 'now' startDate.
last time we talked about
nowbeing an alias tocreationTimestamp, I suppose this just wasn't update yet, right?
I validated and manager server rejects tasks with date in the past
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rzetelskik, tnozicka, zimnx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [tnozicka,zimnx]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![scylla-operator-bot[bot] avatar](https://avatars.githubusercontent.com/in/112385?v=4 "Published by a pub.dev verified publisher"){kind=small}
Flake: https://github.com/scylladb/scylla-operator/issues/1525
/test e2e-gke-parallel
@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gke | d932c871a4607554093db5740bb335827b2d0aa0 | link | true | /test e2e-gke |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Flakes: https://github.com/scylladb/scylla-operator/issues/1433 https://github.com/scylladb/scylla-operator/issues/1525
/test e2e-gke-parallel
