NodeConfig tuning: no scylla container found in pod

[tnozicka]

Describe the bug Nodeconfig tuning shouldn't return an error when a pod is pending but rather check that case and silently requeue. https://github.com/scylladb/scylla-operator/blob/9087a40bda9dcecd2a037523ce64fae85c225b80/pkg/controller/nodeconfigpod/sync_configmaps.go#L56

E0919 14:48:13.416140       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.421637       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.434105       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.455076       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.495926       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.579328       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:13.740675       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:14.061452       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"
E0919 14:48:14.701895       1 nodeconfigpod/controller.go:383] syncing key 'scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0' failed: can't make configmap for pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0": can't get container id: no scylla container found in pod "scylla-manager/scylla-manager-cluster-manager-dc-manager-rack-0"

To Reproduce Steps to reproduce the behavior:

1. Create Operator ...
2. Perform this action ...
3. See error

Expected behavior A clear and concise description of what you expected to happen.

Config Files If relevant, upload your configuration files here using GitHub, there is no need to upload them to any 3rd party services

Logs Please, provide kubectl get events, kubectl logs -n scylla pod-name and other relevant information.

Environment:

• Platform: (GKE, Azure, minikube, custom...)
• Kubernetes version:
• Scylla version:
• Scylla-operator version: e.g.: master, 8e155d0...

Additional context Add any other context about the problem here.