scylla-operator icon indicating copy to clipboard operation
scylla-operator copied to clipboard

Make operator use new Scylla Manager client

Open Choraden opened this issue 3 years ago • 6 comments

Description of your changes: The mermaid client was outdated. This PR updates it to the newest version.

  • Scylla Manager swagger has been updated to this https://github.com/scylladb/scylla-manager/blob/9ad2186d6b6b922ac96ff7c08e45d4ba1b0dd31a/swagger/scylla-manager.json.
  • Makefile for client generation has been created in mermaid client package. It follows Scylla Manager logic of generating clients https://github.com/scylladb/scylla-manager/blob/master/swagger/Makefile.
  • New client has been generated, unnecessary old client code removed, old script to generate client removed.
  • The operator has been adjusted to use new mermaid client.

Choraden avatar Aug 04 '22 11:08 Choraden

  • Mermaid has been renamed to Scylla Manager
  • Rules to update and verify Scylla Manager client have been moved to top level Makefile
  • Swagger has been imported to vendor files

Choraden avatar Sep 05 '22 12:09 Choraden

@zimnx I've addressed your comments PTAL

Choraden avatar Sep 09 '22 09:09 Choraden

Changed names as suggested.

Choraden avatar Sep 09 '22 12:09 Choraden

@tnozicka I've addressed your comments PTAL

Choraden avatar Sep 14 '22 14:09 Choraden

It's on my list for Monday, apologies for the delay. (if you we not to get a review pls ping me on Tue)

tnozicka avatar Sep 23 '22 14:09 tnozicka

@tnozicka ptal

Choraden avatar Oct 06 '22 09:10 Choraden

This PR is being closed because of inactivity. Feel free to reopen if you plan to work on it.

tnozicka avatar Aug 17 '23 13:08 tnozicka