scylla-operator
scylla-operator copied to clipboard
scylladb
Promote PodDisruptionBudgets from V1Beta1 to V1
Description of your changes: During the apply of PodDisruptionBudgets the following warning occured: "policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget".
To fix this, all the PDBs will now come from "k8s.io/api/policy/v1" package.
Please port our PDBs in helm charts and manifests
PDBs in helm charts and manifests ported
Please port our PDBs in helm charts and manifests
PDBs in helm charts and manifests ported
deploy directory is autogenerated, please extract generated changes to separate commit. You can trigger generation via make update
deploydirectory is autogenerated, please extract generated changes to separate commit. You can trigger generation viamake update
Right, thanks!
deploydirectory is autogenerated, please extract generated changes to separate commit. You can trigger generation viamake updateRight, thanks!
examples are also autogenerated, sorry for not pointing it out in previous comment. Please extract it too.
deploydirectory is autogenerated, please extract generated changes to separate commit. You can trigger generation viamake updateRight, thanks!
examplesare also autogenerated, sorry for not pointing it out in previous comment. Please extract it too.
Not a problem, examples extracted.
i think pdb v1 exists since 1.21 (pls double check)
correct
Which releases do you want me to bump? v1.7 only?
Which releases do you want me to bump? v1.7 only?
You are shipping your changes to master, which is what's gonna be in 1.8 so you need to make a new column for 1.8 where you bump the requirements.
Regarding the comments, I bumped:
- Scylla OS to
>=4.6 - Manager to
>=2.6 - Monitoring
>=4.0
Which releases do you want me to bump? v1.7 only?
You are shipping your changes to master, which is what's gonna be in 1.8 so you need to make a new column for 1.8 where you bump the requirements.
I think this fix must also be ported back to the v1.7.x operator. Because the latest K8S version (v1.25.x) is not compatible with the latest operator version (v1.7.x) already.
So, I think we should either drop support for the v1.20- version or make the operator be smart enough and use different API versions on different K8S versions.
I don't wanna mess with multiple API version for a one timer. Given we have already claimed 1.7 will work on >=1.20 we should update it to >=1.20 && <1.25. We'll support 1.25 in v1.8.
Should I apply the upper bound to earlier releases too? If so, is <1.25 right to all of them?
Should I apply the upper bound to earlier releases too? If so, is <1.25 right to all of them?
In a best effort way, that goes for all of them. You could probably only update the supported releases (1.7 and 1.6)
