scylla-monitoring icon indicating copy to clipboard operation
scylla-monitoring copied to clipboard

Non Token Aware queries for counters

Open dahankzter opened this issue 5 years ago • 18 comments

The Non Token Aware Queries graph doesn't seem to be accurate for counters. We have tested both the Go driver (https://github.com/scylladb/gocql/issues/32) and cassandra-stress and both of them shows a large number in this graph but none when switching to integer fields or text for example.

cassandra-stress run:

cassandra-stress counter_write no-warmup cl=QUORUM duration=30s -schema 'replication(factor=2) compaction(strategy=SizeTieredCompactionStrategy)' keyspace=counter -port jmx=7100 -mode cql3 native -rate threads=1

This is both on multi node setups and even single node clusters.

dahankzter avatar Jan 29 '20 13:01 dahankzter

Screenshot from 2020-01-29 14-02-55 Screenshot from 2020-01-29 14-02-36

dahankzter avatar Jan 29 '20 13:01 dahankzter

For future readers: it also might be worth noting that:

  • we used shard-aware drivers
  • scylla_storage_proxy_replica_cross_shard_ops metrics don't indicate any inter-shard operations
  • the behavior is observable even for Scylla ran with --smp 1

jul-stas avatar Jan 29 '20 15:01 jul-stas

@amnonh ping ...

slivne avatar Feb 10 '20 09:02 slivne

@slivne you volunteered to have a look, let me know if you can't

amnonh avatar Feb 18 '20 08:02 amnonh

@slivne @amnonh any update on this one?

gcarmin avatar Mar 08 '20 18:03 gcarmin

@slivne @amnonh any update on this one?

gcarmin avatar Mar 30 '20 11:03 gcarmin

this is the source of the issue: https://github.com/scylladb/scylla/issues/4337

I'll need to followup with gleb on this.

slivne avatar Apr 05 '20 23:04 slivne

@slivne any updates?

amnonh avatar Jun 25 '20 05:06 amnonh

@slivne ping

amnonh avatar Sep 01 '20 08:09 amnonh

@slivne please comment to know if we want to close this

amnonh avatar Nov 01 '20 07:11 amnonh

@vladzcloudius FYI

gcarmin avatar Jan 28 '21 15:01 gcarmin

The counter today indeed is not updated and token-awareness in the dashboards is incorrectly displayed

we will either

  • add counters for local/remote updates of counters
  • remove the number of updates from counters for dashboards to make sure the input on token awarness is correct

slivne avatar Jan 28 '21 16:01 slivne

@amnonh Vlad told me to ping you on this issue!

mrsinham avatar Jan 29 '21 09:01 mrsinham

@slivne we need to link to a scylla issue

amnonh avatar Feb 04 '21 08:02 amnonh

@jul-stas is looking at this https://github.com/scylladb/scylla/issues/4337

@amnonh you can also try and have a temp solution by removing counter updates for now - it will not be as good but will be a stop the gap till scylla releases will havea solution

slivne avatar Feb 04 '21 09:02 slivne

There is a workaround in Scylla Monitoring 3.6.2

amnonh avatar Mar 07 '21 12:03 amnonh

@amnonh what is the workaround?

gcarmin avatar Mar 07 '21 12:03 gcarmin

when counters or LWT in use, it will not show non-token aware

amnonh avatar Mar 07 '21 13:03 amnonh