feature(artifact_test): testing the output of perftune.py
perftune.py is a script within seastar (which is a part of scylla_setup) that configures several system parameters, like the amount of CPU cores that are designated to handle IRQ, and which are not.
I have recorded the expected results as of master 20230717.567b4536892f in defaults/perftune_results.json, and the test will compare them to the output of the script.
Ref: https://github.com/scylladb/scylla-enterprise/issues/2909
Replacement of #6192
Testing
- [ ] 🟢 https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-docker-test/34/
- [ ] 🟢 https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-ami-test/16/
- [ ] 🟢 https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-azure-image-test/52/
- [ ] 🟢 https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-gce-image-test/4/
- [ ] :clock1: https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-ami-arm-test/5/
- [ ] :clock1: https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-rocky8-test/9/
- [ ] :clock1: https://jenkins.scylladb.com/job/scylla-staging/job/fruch/job/artifacts-ubuntu2004-arm-test/16/
PR pre-checks (self review)
- [ ] I added the relevant
backportlabels - [x] I didn't leave commented-out/debugging code
Reminders
- Add New configuration option and document them (in
sdcm/sct_config.py) - Add unit tests to cover my changes (under
unit-test/folder) - Update the Readme/doc folder relevant to this change (if needed)
⚠️ The sha of the head commit of this PR conflicts with #6192. Mergify cannot evaluate rules on this PR. ⚠️
@roydahan have you seen this one ?
Maybe it's a good opportunity to verify defaults shipped with AMI? Could be in followup too if we want it.
defaults you mean the content of io_properites.yaml ?
Maybe it's a good opportunity to verify defaults shipped with AMI? Could be in followup too if we want it.
defaults you mean the content of
io_properites.yaml?
yes, how much we differ from that - shouldn't be much (what is much I don't know yet)
Maybe it's a good opportunity to verify defaults shipped with AMI? Could be in followup too if we want it.
defaults you mean the content of
io_properites.yaml?yes, how much we differ from that - shouldn't be much (what is much I don't know yet)
this would be a followup, and a bit more complex to define clearly we are struggling with it on some perf issues.