scylla-cluster-tests icon indicating copy to clipboard operation
scylla-cluster-tests copied to clipboard

Published 20 hours ago • verified publisher icon scylladb

fix(artifacts): replace centos9-selinux with rocky9-selinux

Open fruch opened this issue 1 year ago • 2 comments

sine there are bugs related centos9 stream we are not gonna attend to. switching the test case to work with rocky9

Ref: https://github.com/scylladb/scylladb/issues/19325

Testing

  • [x] 🔴 rocky9-selinux - https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/fruch/job/artifacts-rocky9-selinux-test/2/
  • [ ] run with a fix from @syuu1228 -

PR pre-checks (self review)

  • [ ] I added the relevant backport labels
  • [x] I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

fruch avatar Sep 09 '24 06:09 fruch

@roydahan @syuu1228

https://github.com/scylladb/scylladb/issues/19325 happens also on rocky9, we back in square one.

fruch avatar Sep 09 '24 07:09 fruch

@yaronkaikov @syuu1228

should we push this replacement, of wait for the fix to be confirmed ? (since centos9-selinux are failing on master and some releases)

fruch avatar Sep 12 '24 06:09 fruch

@yaronkaikov @syuu1228

should we push this replacement, of wait for the fix to be confirmed ? (since centos9-selinux are failing on master and some releases)

@yaronkaikov @syuu1228, we still need this replacement ? or cento9 is now fixed too ?

fruch avatar Sep 26 '24 14:09 fruch

@yaronkaikov @syuu1228 should we push this replacement, of wait for the fix to be confirmed ? (since centos9-selinux are failing on master and some releases)

@yaronkaikov @syuu1228, we still need this replacement ? or cento9 is now fixed too ?

I think we always should test on rocky9 (or alma9) instead of centos9 stream, since centos9 stream is like "beta" distribution of RHEL9, may contain bugs which does not exist on RHEL9. In fact we saw such bug on https://github.com/scylladb/scylladb/issues/19325, at this time the bug also released on RHEL9, though.

syuu1228 avatar Sep 30 '24 09:09 syuu1228

@yaronkaikov @syuu1228 should we push this replacement, of wait for the fix to be confirmed ? (since centos9-selinux are failing on master and some releases)

@yaronkaikov @syuu1228, we still need this replacement ? or cento9 is now fixed too ?

I think we always should test on rocky9 (or alma9) instead of centos9 stream, since centos9 stream is like "beta" distribution of RHEL9, may contain bugs which does not exist on RHEL9. In fact we saw such bug on https://github.com/scylladb/scylladb/issues/19325, at this time the bug also released on RHEL9, though.

Sounds like testing on centos9 stream, did give us a heads-up on an issue that ended being on all of the downstreams.

The current situation is that both works ? if so maybe we should leave them both ?

fruch avatar Sep 30 '24 09:09 fruch

If both works, I'm fine with leave them both for now. We could replace centos9 to RHEL9 to be on the safe side of our support matrix, but it doesn't worth the investment at this point.

roydahan avatar Sep 30 '24 12:09 roydahan

If both works, I'm fine with leave them both for now. We could replace centos9 to RHEL9 to be on the safe side of our support matrix, but it doesn't worth the investment at this point.

centos9 started passing

https://argus.scylladb.com/test/070b0d31-e1ec-4173-abf5-39122f8c4011/runs?additionalRuns

And rocky9 passed on staging

As for support of RHEL9, it shouldn't be that hard to add it

fruch avatar Sep 30 '24 12:09 fruch

@roydahan @yaronkaikov

changed this PR to introduce rocky9-selinux, and not remove centos9-selinux

fruch avatar Oct 06 '24 10:10 fruch