scylla-cluster-tests
scylla-cluster-tests copied to clipboard
fix(nodebootstrapabortmanager): always clean scylla data before rebootstrap
with raft topology, node which failed to bootstrap , removed from cluster
and banned. Need to clean all scylla data before rebootstrap.
Depending on log message after which bootstrap is going to be aborted,
Bootstrap process could be finished first than it was aborted
and node could be added to cluster.
Added additional checks for successful bootstrap before aborting process
Also added more error log messages with warning severity, because they
are expected if bootstrap process was aborted.
Testing
- Test passed with single nemesis
- Regular job
PR pre-checks (self review)
- [ ] I added the relevant
backportlabels - [ ] I didn't leave commented-out/debugging code
Reminders
- Add New configuration option and document them (in
sdcm/sct_config.py) - Add unit tests to cover my changes (under
unit-test/folder) - Update the Readme/doc folder relevant to this change (if needed)
Fix for issue: https://github.com/scylladb/scylla-cluster-tests/issues/7448
@aleksbykov still draft?
@aleksbykov still draft?
@soyacz it is in staging now. working with it
@aleksbykov still draft?
@soyacz it is in staging now. working with it
@temichus it was in staging month ago ? can someone attend this one ?
@aleksbykov still draft?
@soyacz it is in staging now. working with it
@temichus it was in staging month ago ? can someone attend this one ?
@fruch it's on Stabilization/testing. @aleksbykov will continue working on it next week
To avoid a lot of update messages, all commits and current activity is on branch https://github.com/aleksbykov/scylla-cluster-tests/commits/fix-bootstrap-after-bootstrap-failed-staging/ All jobs are running under: https://argus.scylladb.com/test/d635e138-c81f-40a6-913b-db20231447d4/runs?additionalRuns[]=16ff6f94-e8cd-430f-8b23-1938e28e86c5
@soyacz @vponomaryov @fruch can you review?
Fixed according comments. Latest run passed
I've rebased and updated code for F821 rule